[EventDispatcher] Replace deprecated implicit nullable#240
Merged
JoshuaEstes merged 1 commit intoSonsOfPHP:mainfrom Jul 24, 2025
Merged
[EventDispatcher] Replace deprecated implicit nullable#240JoshuaEstes merged 1 commit intoSonsOfPHP:mainfrom
JoshuaEstes merged 1 commit intoSonsOfPHP:mainfrom
Conversation
JoshuaEstes
approved these changes
Jul 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage ? 79.41%
Complexity ? 1699
=======================================
Files ? 231
Lines ? 4178
Branches ? 0
=======================================
Hits ? 3318
Misses ? 860
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation includes an implicit nullable parameter, which is deprecated in PHP 8.4 and causing deprecation notices. This PR makes the implicit type explicit.
Note: I haven't updated the changelog for this minor change but can by request.
Checklist